Don't block merges on linkcheck - #2128
Open
woodruffw wants to merge 2 commits into
Open
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Member
Author
|
I had to widen this to non-main pushes as well, since first-party PRs will also trigger this since they receive the |
webknjaz
reviewed
Sep 8, 2026
| # Don't block PRs, merge groups, or non-main pushes on unrelated linkcheck failures. | ||
| continue-on-error: >- | ||
| ${{ toJSON(github.event_name == 'pull_request' || github.event_name == 'merge_group' || | ||
| (github.event_name == 'push' && github.ref != 'refs/heads/main')) }} |
Member
There was a problem hiding this comment.
Suggested change
| (github.event_name == 'push' && github.ref != 'refs/heads/main')) }} | |
| (github.event_name == 'push' && github.ref_name != github.event.repository.default_branch)) }} |
webknjaz
reviewed
Sep 8, 2026
| ${{ toJSON(github.event_name == 'pull_request') }} | ||
| # Don't block PRs, merge groups, or non-main pushes on unrelated linkcheck failures. | ||
| continue-on-error: >- | ||
| ${{ toJSON(github.event_name == 'pull_request' || github.event_name == 'merge_group' || |
Member
There was a problem hiding this comment.
Something like this seems nicer
Suggested change
| ${{ toJSON(github.event_name == 'pull_request' || github.event_name == 'merge_group' || | |
| ${{ toJSON(contains(['merge_group', 'pull_request'], github.event_name) || |
Member
Not sure we really need to care about pushes, though. What fails is merge queue events. |
Member
Author
FWICT the merge queue only becomes available after the push-triggered checks succeed, since the linkcheck is marked as required on that trigger still. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this was an oversight in #2035 -- it doesn't make sense to allow linkchecks to pass PR gates, only to bounce them at the merge group.
📚 Documentation preview 📚: https://python-packaging-user-guide--2128.org.readthedocs.build/en/2128/