Skip to content

Don't block merges on linkcheck - #2128

Open
woodruffw wants to merge 2 commits into
mainfrom
ww/no-linkcheck-on-merge-groupo
Open

Don't block merges on linkcheck#2128
woodruffw wants to merge 2 commits into
mainfrom
ww/no-linkcheck-on-merge-groupo

Conversation

@woodruffw

@woodruffw woodruffw commented Sep 8, 2026

Copy link
Copy Markdown
Member

I believe this was an oversight in #2035 -- it doesn't make sense to allow linkchecks to pass PR gates, only to bounce them at the merge group.


📚 Documentation preview 📚: https://python-packaging-user-guide--2128.org.readthedocs.build/en/2128/

Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw

Copy link
Copy Markdown
Member Author

I had to widen this to non-main pushes as well, since first-party PRs will also trigger this since they receive the push event.

@woodruffw
woodruffw requested a review from webknjaz September 8, 2026 19:20
# Don't block PRs, merge groups, or non-main pushes on unrelated linkcheck failures.
continue-on-error: >-
${{ toJSON(github.event_name == 'pull_request' || github.event_name == 'merge_group' ||
(github.event_name == 'push' && github.ref != 'refs/heads/main')) }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(github.event_name == 'push' && github.ref != 'refs/heads/main')) }}
(github.event_name == 'push' && github.ref_name != github.event.repository.default_branch)) }}

${{ toJSON(github.event_name == 'pull_request') }}
# Don't block PRs, merge groups, or non-main pushes on unrelated linkcheck failures.
continue-on-error: >-
${{ toJSON(github.event_name == 'pull_request' || github.event_name == 'merge_group' ||

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this seems nicer

Suggested change
${{ toJSON(github.event_name == 'pull_request' || github.event_name == 'merge_group' ||
${{ toJSON(contains(['merge_group', 'pull_request'], github.event_name) ||

@webknjaz

webknjaz commented Sep 8, 2026

Copy link
Copy Markdown
Member

since first-party PRs will also trigger this since they receive the push event.

Not sure we really need to care about pushes, though. What fails is merge queue events.

@woodruffw

Copy link
Copy Markdown
Member Author

since first-party PRs will also trigger this since they receive the push event.

Not sure we really need to care about pushes, though. What fails is merge queue events.

FWICT the merge queue only becomes available after the push-triggered checks succeed, since the linkcheck is marked as required on that trigger still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants