Repository navigation
Fix vsce packaging under pnpm and exclude dev-only files - #39
Merged
Merged
Conversation
Pass --no-dependencies to `vsce package`: vsce otherwise runs `npm list`, which fails on pnpm's node_modules layout, and runtime dependencies are already bundled into dist/extension.js by webpack. Extend .vscodeignore so the .vsix no longer ships local and dev-only files (.claude/, .mypy_cache/, scripts/, lockfiles, eslint config, pyproject.toml, .python-version). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage Report for CI Build 42407535797Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.4%) to 65.257%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions4 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vsce-packagescript: add--no-dependencies. Without it,vsce packagerunsnpm list --production, which fails withELSPROBLEMSon pnpm'snode_moduleslayout, sopnpm run vsce-packagedidn't work. Runtime dependencies are already bundled intodist/extension.jsby webpack, so vsce doesn't need to collect them..vscodeignore: exclude development-only files that were being shipped in the.vsix:.claude/,.mypy_cache/,scripts/,eslint.config.js,pnpm-lock.yaml,pnpm-workspace.yaml,pyproject.toml,uv.lockand.python-version. The language server'spyproject.tomllookup reads the user's workspace root, not the extension's own copy, so excluding it is safe.Test plan
pnpm run vsce-packagesucceeds (python-ta.vsix, 2891 files, 18.69 MB)vsce ls --no-dependenciesoutsidebundled/libs/lists onlydist/,bundled/tool/,README.md,CHANGELOG.md,LICENSEandpackage.json.vsixand confirm the extension activates and reports diagnostics🤖 Generated with Claude Code