fix: reject repeated duration components in the Rust parser - #1005
Open
vzer200 wants to merge 1 commit into
Open
fix: reject repeated duration components in the Rust parser#1005vzer200 wants to merge 1 commit into
vzer200 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust parser accepts
P12M4Mas four months andPT12M3M1Mas sixteen minutes, while the Python fallback rejects both. Track consumed units independently of their values so repeated components and reversed components after zero (such asPT0M1H) raiseParserError. Reset that state atTto keep months and minutes independent.Addresses the repeated-component portion of #833. Overflow, empty
PT, week-mixing permissiveness and arithmetic are unchanged.Validation on Windows with Python 3.12.14 and Rust 1.98.1:
needless_late_initatsrc/python/helpers.rs:90on baseline and patch; allowing only that lint passes. No suppression was added to the repository.Pull Request Check List
Prepared with Codex. A separate agent reviewed the source and ran independent baseline comparisons before submission.