Repository navigation
0.4.1: default deliverables reach sessions - #15
Closed
Marius1311 wants to merge 1 commit into
Closed
Marius1311 wants to merge 1 commit into
Marius1311 wants to merge 1 commit into
Conversation
Claude Code passes a plugin option to hooks only once the user saves it, so the manifest default never reached sessions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011aQpF4MA9v7dTVK1FqMMVJ
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
Closing: Claude Code doesn't pass a userConfig default to hooks or skill text, and this would work around that in one plugin only. Users set the option in /config instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Code sets
CLAUDE_PLUGIN_OPTION_<KEY>for a hook only once the user has saved that option, and doesn't apply the manifest'sdefault. So anyone who never setdeliverablesgot no default line, and every task asked for its deliverables. When the variable is unset, the session-start hook now reads the default fromplugin.json. A saved blank still means "ask".The test had set the variable itself, so it never covered the unset case. It now does.
🤖 Generated with Claude Code
https://claude.ai/code/session_011aQpF4MA9v7dTVK1FqMMVJ