Skip to content

Use gdsc_synced_poweroff_disable() callback for USB PHY GDSCs on Glymur #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kona-jagadeesh wants to merge 2 commits into
base: qcom-7.2
Choose a base branch
from
+41 −1
Open

Use gdsc_synced_poweroff_disable() callback for USB PHY GDSCs on Glymur #1184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dd5767
WORKAROUND: clk: qcom: gdsc: Add gdsc_synced_poweroff_disable callback
kona-jagadeesh May 5, 2026
8259207
WORKAROUND: clk: qcom: gcc-glymur: Use synced poweroff for USB GDSC's
kona-jagadeesh Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions drivers/clk/qcom/gcc-glymur.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7784,6 +7784,7 @@ static struct gdsc gcc_usb20_prim_gdsc = {
.clk_dis_wait_val = 0xf,
.pd = {
.name = "gcc_usb20_prim_gdsc",
.power_off = gdsc_synced_poweroff_disable,
},
.pwrsts = PWRSTS_OFF_ON,
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
Expand All @@ -7796,6 +7797,7 @@ static struct gdsc gcc_usb30_mp_gdsc = {
.clk_dis_wait_val = 0xf,
.pd = {
.name = "gcc_usb30_mp_gdsc",
.power_off = gdsc_synced_poweroff_disable,
},
.pwrsts = PWRSTS_OFF_ON,
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
Expand All @@ -7808,6 +7810,7 @@ static struct gdsc gcc_usb30_prim_gdsc = {
.clk_dis_wait_val = 0xf,
.pd = {
.name = "gcc_usb30_prim_gdsc",
.power_off = gdsc_synced_poweroff_disable,
},
.pwrsts = PWRSTS_OFF_ON,
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
Expand All @@ -7820,6 +7823,7 @@ static struct gdsc gcc_usb30_sec_gdsc = {
.clk_dis_wait_val = 0xf,
.pd = {
.name = "gcc_usb30_sec_gdsc",
.power_off = gdsc_synced_poweroff_disable,
},
.pwrsts = PWRSTS_OFF_ON,
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
Expand All @@ -7832,6 +7836,7 @@ static struct gdsc gcc_usb30_tert_gdsc = {
.clk_dis_wait_val = 0xf,
.pd = {
.name = "gcc_usb30_tert_gdsc",
.power_off = gdsc_synced_poweroff_disable,
},
.pwrsts = PWRSTS_OFF_ON,
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
Expand All @@ -7844,6 +7849,7 @@ static struct gdsc gcc_usb3_mp_ss0_phy_gdsc = {
.clk_dis_wait_val = 0x2,
.pd = {
.name = "gcc_usb3_mp_ss0_phy_gdsc",
.power_off = gdsc_synced_poweroff_disable,
},
.pwrsts = PWRSTS_OFF_ON,
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
Expand All @@ -7856,6 +7862,7 @@ static struct gdsc gcc_usb3_mp_ss1_phy_gdsc = {
.clk_dis_wait_val = 0x2,
.pd = {
.name = "gcc_usb3_mp_ss1_phy_gdsc",
.power_off = gdsc_synced_poweroff_disable,
},
.pwrsts = PWRSTS_OFF_ON,
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
Expand Down Expand Up @@ -7904,6 +7911,7 @@ static struct gdsc gcc_usb_0_phy_gdsc = {
.clk_dis_wait_val = 0x2,
.pd = {
.name = "gcc_usb_0_phy_gdsc",
.power_off = gdsc_synced_poweroff_disable,
},
.pwrsts = PWRSTS_OFF_ON,
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
Expand All @@ -7916,6 +7924,7 @@ static struct gdsc gcc_usb_1_phy_gdsc = {
.clk_dis_wait_val = 0x2,
.pd = {
.name = "gcc_usb_1_phy_gdsc",
.power_off = gdsc_synced_poweroff_disable,
},
.pwrsts = PWRSTS_OFF_ON,
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
Expand All @@ -7928,6 +7937,7 @@ static struct gdsc gcc_usb_2_phy_gdsc = {
.clk_dis_wait_val = 0x2,
.pd = {
.name = "gcc_usb_2_phy_gdsc",
.power_off = gdsc_synced_poweroff_disable,
},
.pwrsts = PWRSTS_OFF_ON,
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
Expand Down
29 changes: 29 additions & 0 deletions drivers/clk/qcom/gdsc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,3 +730,32 @@ int gdsc_gx_disable(struct generic_pm_domain *domain)
return 0;
}
EXPORT_SYMBOL_GPL(gdsc_gx_disable);

/*
* USB and PCIE GDSCs require GDSC to be kept ON even during system system
* for USB host mode and PCIE non-D3 cold usecases. The below callback can
* be used for such GDSCs where the consumer drivers can set GenPD's
* synced_poweroff flag using dev_pm_genpd_synced_poweroff() before suspend
* to disable the GDSC and can avoid setting the flag to keep the GDSC ON
* during suspend.
*/
int gdsc_synced_poweroff_disable(struct generic_pm_domain *domain)
{
struct gdsc *sc = domain_to_gdsc(domain);

/*
* For GDSCs with VOTABLE flag(e.g. PCIE), status must not be polled
* during disable. However, gdsc_disable() polls for status when
* synced_poweroff is set. Use gdsc_toggle_logic() with wait = false
* to skip status polling for VOTABLE GDSCs during power-off.
*/
if (domain->synced_poweroff)
return gdsc_toggle_logic(sc, GDSC_OFF, false);

/* Remove parent-supply placed in enable */
if (sc->rsupply)
return regulator_disable(sc->rsupply);

return 0;
}
EXPORT_SYMBOL_GPL(gdsc_synced_poweroff_disable);
3 changes: 2 additions & 1 deletion drivers/clk/qcom/gdsc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ int gdsc_register(struct gdsc_desc *desc, struct reset_controller_dev *,
void gdsc_unregister(struct gdsc_desc *desc);
int gdsc_gx_do_nothing_enable(struct generic_pm_domain *domain);
int gdsc_gx_disable(struct generic_pm_domain *domain);
#define gdsc_synced_poweroff_disable gdsc_gx_disable
int gdsc_synced_poweroff_disable(struct generic_pm_domain *domain);
#else
static inline int gdsc_register(struct gdsc_desc *desc,
struct reset_controller_dev *rcdev,
Expand All @@ -104,5 +104,6 @@ static inline int gdsc_register(struct gdsc_desc *desc,
}

static inline void gdsc_unregister(struct gdsc_desc *desc) {};
static int gdsc_synced_poweroff_disable(struct generic_pm_domain *domain) {};
#endif /* CONFIG_QCOM_GDSC */
#endif /* __QCOM_GDSC_H__ */