Repository navigation
fix(tui): always start the sidebar closed - #117
Merged
Merged
Conversation
The ctrl+b toggle persisted "auto" into kv.json, so a new session on a terminal wider than 120 columns reopened the sidebar. Remove the persisted sidebar kv signal; visibility is driven only by the session-local sidebarOpen signal. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The TUI right sidebar starts hidden in this fork, but toggling it open wrote
"auto"into the persisted kv store (kv.json), so the next session on a terminal wider than 120 columns started with the sidebar open. This removes the persistedsidebarkv signal entirely: visibility is now driven only by the session-localsidebarOpensignal, so every session starts with the sidebar closed andctrl+b/<leader>bonly affects the current session.packages/tui/src/routes/session/index.tsx: dropkv.signal("sidebar", …), simplifysidebarVisibleand the toggle command; stalesidebarkeys in existingkv.jsonfiles are simply never read (no migration needed)DIVERGENCES.md: updated the existing sidebar row for this file (supersedes the"auto"→"hide"default divergence)CHANGELOG.md: Unreleased entrypackages/tui/test/sidebar-hint.view.test.tsx: reworded a comment referencing the old persistenceTest plan
bun typecheckinpackages/tuipassesbun test test/sidebar-hint.view.test.tsx(exercises the toggle path) passeskv.jsonwith"sidebar":"auto", launched the TUI at 130 columns — sidebar starts closed;ctrl+bopens it; after quit + relaunch into the same session it starts closed again🤖 Generated with Claude Code