[quickbeard]

The two defects the sidebar tests turned up, fixed on every surface that has them.

1. Session row ⋮ menus ignored their first click

Root cause, traced with a DOM-mutation and pointer-event trace. createHomeModel's records memo mints a fresh {session, project, projectName} wrapper per session every time it runs, and it runs on recomputes that changed nothing it reads — the projects memo alone hands back a new array on a pointerdown, three times over. The lists rendered those wrappers through a reference-keyed <For>, so every row's DOM was destroyed and rebuilt between pointerdown and mouseup. With no surviving common ancestor the browser fires no click event at all — the trace shows pointerdown on the icon, the row subtree removed and re-added, then mouseup on a different node and no click anywhere. The second click landed because the rebuild was over.

Fix: iterate stable ids, not object references, so a rebuilt record set updates rows in place.

• Sidebar Recents (app-sidebar.tsx, fork-only) — keyed by session id.
• View all (home.tsx, upstream) — keyed at both levels: groups() by group id, and each group's sessions by session id. groupSessions mints new group objects too, so keying only the inner list would still have rebuilt everything.

This was never only about the first click. The same rebuild could close an already-open menu, or drop a rename part-way through typing, whenever anything refreshed in the background.

The ⋯ menu beside a session title was never affected — it has no such list above it.

2. View all was drawn into space too small to hold it

Below roughly a 380px-tall window the sidebar's flexible area drops under one row (12px at 380, none at 360). recentsRowCapacity clamps the session rows to zero, but nothing withheld the View all row, and the list clips with overflow-hidden — so it was drawn cut in half, or invisibly. New fitsRecentsRow gates it on one whole row of space: whole or absent, never cut.

Tests

Every new or extended assertion was run against the unfixed code and fails there — checked, not assumed:

• sidebar-session-menu-first-click.spec.ts and home-session-menu-first-click.spec.ts — one click opens the menu; and a forced record rebuild leaves both the open menu and the row's DOM node identity intact.
• The height sweep in sidebar-section-collapse.spec.ts now runs past the old 400px floor down to 320.
• fitsRecentsRow unit tests, including a cross-check that it never disagrees with recentsRowCapacity.

Divergences

home.tsx is upstream, so it gets a DIVERGENCES.md row. The on-conflict note spells out that reverting to <For each={groups()}> / <For each={group.sessions}> reintroduces the bug, and points at the regression spec to use if upstream ever makes those references stable.

One approach I tried and dropped: a stable-identity cache in the fork-only home-model.tsx would have fixed both surfaces with no upstream edit, but it does not fix the View all list — those rows come from groupSessions' own arrays — so I reverted it rather than leave unproven machinery in place.

Verification

• bun typecheck (packages/app) — clean
• bun test (packages/app) — 626 pass (up 7)
• bun test:e2e:local — 101 pass (up 4), 2 fail in remote-session-settings.spec.ts; both fail identically on clean main, pre-existing and unrelated
• bun lint — identical to the main baseline (4740 warnings, 1 pre-existing error)

🤖 Generated with Claude Code