Repository navigation
fix(desktop): restore homepage and author so the deb builds - #194
Merged
Merged
Conversation
#171 deleted `homepage` and `author` from packages/desktop/package.json as part of the rebrand — correctly, since they pointed at opencode.ai and hello@opencode.ai, and shipping a CoDev package that names upstream as its maintainer would be wrong. Removing them outright broke `deb` and `rpm` packaging, though: electron-builder derives the Debian Maintainer field from `author.email` and refuses to build any fpm target without `homepage`, so `bun run package:linux` has failed since 2026-08-08 with Please specify project homepage It is required to set Linux .deb package maintainer. They are back, carrying fork values rather than upstream ones. Both match what scripts/copy-metainfo.ts already writes into the AppStream metainfo, so the deb and the metainfo now agree instead of one naming a developer the other does not: homepage https://github.com/quickbeard/codev-code (= <url type="homepage">) author CoDev <minhnh49@viettel.com.vn> (= <developer><name>) Nothing else consumes these fields — the app id, product name and artifact names all come from electron-builder.config.ts. Verified by building the deb from this tree with no CLI overrides: exit 0, and `dpkg-deb -f` reports Package codev-code, Maintainer CoDev <minhnh49@viettel.com.vn>, Homepage https://github.com/quickbeard/codev-code. AppImage and the Windows nsis target were never affected — they do not use fpm. The rpm target now gets past metadata and stops on a missing `rpmbuild`, which is a host dependency (apt-get install rpm), not a repo one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bun run package:linuxhas failed since 2026-08-08:#171 deleted
homepageandauthorfrompackages/desktop/package.jsonas part of the rebrand. That was right as far as it went — they pointed athttps://opencode.aiandhello@opencode.ai, and a CoDev package naming upstream as its maintainer would be wrong. But electron-builder derives the DebianMaintainerfield fromauthor.emailand refuses to build any fpm target withouthomepage, so deleting them outright tookdebandrpmwith it.Nothing caught it: no workflow packages the desktop app, and
AppImage,nsisanddmgdon't use fpm, so the only broken targets are the two nobody builds in CI.The fix
Both fields are back with fork values, matching what
scripts/copy-metainfo.tsalready writes into the AppStream metainfo — so the deb and the metainfo now agree, instead of one naming a developer the other doesn't:homepagehttps://github.com/quickbeard/codev-code<url type="homepage">authorCoDev <minhnh49@viettel.com.vn><developer><name>CoDev</name>Nothing else reads these — app id, product name and artifact names all come from
electron-builder.config.ts.Verification
Built the deb from this tree with no CLI overrides — exit 0 — and read the metadata back out of the package:
The
rpmtarget now gets past metadata and stops on a missingrpmbuild— a host dependency (apt-get install rpm), not a repo one. AppImage and the Windows nsis build were never affected.DIVERGENCES.mdrow updated: it described the removal as consequence-free, which is what let this sit unnoticed.No
CHANGELOG.mdentry — this is packaging metadata, and the fork ships no desktop build yet, so nothing user-facing changed.🤖 Generated with Claude Code