Repository navigation
fix(sandbox): run the guest on Node 24 and probe /path in the e2es - #207
Merged
Merged
Conversation
The guest ran the server bundle on Node 22, whose node:sqlite lacks StatementSync.setReturnArrays — the bundle is built against Electron's Node 24, so every DB-touching route died with UnknownError while /global/health kept passing, which is exactly what the health-only e2e checked. Track the Electron Node major (24) in the image, and make both e2e drivers also probe /path, the cheapest route that boots the instance store. Found via the first in-app run: the sandbox reached Ready but the project picker listed nothing; reproduced in the guest rootfs under Docker, where the server log carried the TypeError. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First in-app e2e finding: the sandbox reaches Ready and health-checks green, but every DB-touching route (
/path, fs, pty, sessions) fails withUnknownError. The guest server log has the cause:The guest image shipped Node v22.15.0, whose
node:sqlitehas noStatementSync.setReturnArrays; the server bundle is developed and run against Electron 42's Node 24./global/healthnever touches the instance store, so the boot-time health poll — and both e2e drivers, which only checked health — passed on a guest that couldn't serve anything real.Changes:
image/Dockerfile:NODE_VERSIONv22.15.0 → v24.19.0 (latest v24; tracks the Electron Node major), with a comment stating the constraintscript/e2e-vz.ts,script/e2e-wsl.ts: after the health check, probe/pathwith the same credentials and fail the run if it isn't 200 — the cheapest route that boots the instance storeReproduced and verified in the guest rootfs under Docker (same launcher, env, and cwd as
codev-init):/path→ UnknownError,node -econfirmssetReturnArrays: undefinedon the shipped Node 22.Requires an image rebuild + republish; the published
1.18.4-8images are unusable beyond health, so they'll be replaced rather than kept alongside. Rebuild + container verification + vz boot test to follow on this branch's image before upload.🤖 Generated with Claude Code