Repository navigation
fix(sandbox): point image downloads at the codev storage prefix - #230
Merged
Merged
Conversation
The bucket moved the sandbox images from codev-code/sandbox to codev/sandbox, and the old prefix now returns 403 — so every sandbox create failed at the manifest fetch. Repoint the base URL; the manifest URL and every asset URL the build script generates follow from it. Verified against the live bucket: the manifest and all four artifacts resolve at the new prefix with the expected sizes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
quickbeard
added a commit
that referenced
this pull request
Aug 15, 2026
The bucket moved the sandbox images from codev-code/sandbox to codev/sandbox and #230 repointed SANDBOX_IMAGES_BASE_URL, but publish-image.ts kept its own hardcoded copy of the old prefix. Every upload therefore landed under a path that reads 403, while the manifest.json clients actually fetch was never touched: the publish printed "published sandbox image <version>" and changed nothing. Derive the destinations from the manifest's own asset URLs and SANDBOX_MANIFEST_URL instead, via sandboxStorageObjectKey — the object key is the URL path minus the bucket segment, which CODEV_STORAGE_TARGET already carries. Publishing now goes exactly where the manifest says the artifacts live, so the two sides cannot drift again; the version guard above already pins those URLs to the version being published. Verified with a synthetic out dir: the printed mc commands target codev/sandbox/<version>/<artifact> and codev/sandbox/manifest.json, artifacts before the manifest. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bucket moved the sandbox images from
codev-storage/codev-code/sandbox/…tocodev-storage/codev/sandbox/…, and the old prefix now returns 403. SinceSANDBOX_MANIFEST_URLderives fromSANDBOX_IMAGES_BASE_URL, every sandbox create currently fails at the manifest fetch.One-line change to the base URL. Everything else follows from it: the manifest URL clients read, and the asset URLs
build-image.tsstamps into future manifests.Verified against the live bucket
Sizes match the freshly built artifacts. Package suite: 103 pass / 2 skip.
Companion action outside this PR
The manifest currently published at the new path was generated before this change, so its embedded
urlfields still point at the deadcodev-codeprefix — a client would fetch the manifest successfully and then 403 on every asset. I have corrected the local copy in~/Downloads/codev/manifest.json(URLs only; hashes and byte counts untouched, and each corrected URL was re-verified against the bucket). That 1 KB file needs re-uploading tocodev/sandbox/manifest.json— no tarball re-upload needed.🤖 Generated with Claude Code