Repository navigation
feat(app): mount folders from the Work sidebar button - #254
Merged
Merged
Conversation
The folder button beside Projects on the Work side opened the Code behavior — a directory picker over the sandbox's own filesystem — but folders reach a sandbox by being mounted, not picked. On Work it now opens the sandbox's mount dialog, the same one as the server menu item in Settings, which is renamed from "Folders..." to "Mount project" to match, as is the dialog title. The dialog's intro line drops the without-asking warning. Code keeps the existing Add project behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
DialogSandboxMounts snapshotted config.mounts into its store once, at component creation. Opened before the sandboxes query had data — easy moments after launch — the snapshot froze as an empty list while the rest of the dialog filled in reactively, so the dialog showed only the project folder, read as dirty, and Save wrote the empty list back: every extra folder silently unmounted while its seeded project stayed in the sidebar looking mounted. The editor is now created only once the sandbox's state exists, behind a loading dialog, so the snapshot is always taken from loaded state. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
quickbeard
force-pushed
the
mount-project-button
branch
from
August 17, 2026 06:38
5b576f5 to
2ec0e04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
folder-add-lefticon; the Work variant carries its owndata-action="work-mount-project"hook, and Code keepshome-add-projectand the existing Add project behavior untouched.sandbox.server.mountskey, so they cannot drift apart.Why
Folders reach a sandbox by being mounted, not picked: the guest-filesystem picker on Work invited the misreading that it would add a host folder, while the actual mount flow was hidden behind a menu in Settings.
Notes
app-sidebar.tsxis fork-only and the changed i18n keys are fork-added, so no DIVERGENCES.md update is needed; the user-facing change is recorded in CHANGELOG.md.HomeServerRow(upstreamhome.tsx) still shows its per-row Add project button with the old guest-picker behavior. Changing that means adding a prop to an upstream file, left for a follow-up decision.bun typecheckand the sidebar/sandbox unit tests pass frompackages/app.🤖 Generated with Claude Code