Repository navigation
test(desktop): assert the vmm helper path with the host's separator - #267
Merged
Merged
Conversation
The codev-vmm resource test compared a path built by path.join against a forward-slash literal, so it only passed on POSIX and failed on every Windows run: the config joins vmmHelperSource from rootDir, which gives "...\codev-sandbox\native\vzhelper\dist\codev-vmm" on Windows. Join the expected suffix too, so the assertion is about where the helper comes from rather than about which platform runs the test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
quickbeard
force-pushed
the
vmm-test-path
branch
from
August 19, 2026 02:52
f0ed4cb to
0d29f30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ships and re-signs the codev-vmm helper on macOSfailed on every Windows run of the desktop suite, onmain, unrelated to any change under test.The config builds the resource path with
path.joinfromrootDir:so on Windows it is
C:\works\codev-code\packages\codev-sandbox\native\vzhelper\dist\codev-vmm, while the test assertedtoEndWith("codev-sandbox/native/vzhelper/dist/codev-vmm"). Forward slashes, so the assertion could only hold on POSIX.Joining the expected suffix as well keeps the test asserting what it means — that the helper is sourced from that location — instead of incidentally asserting the platform. It still fails if the resource moves or the
toname changes.Desktop suite on Windows: 134 pass, 0 fail (was 133 pass, 1 fail). Unchanged on POSIX, where
path.joinyields the same string the literal did.Found while working on #266; split out because it is an independent pre-existing failure and does not belong in that PR.
🤖 Generated with Claude Code