Repository navigation
feat(app): list files first in the V2 composer @ mention menu - #289
Merged
Merged
Conversation
The desktop/web V2 prompt input kept upstream's reference → agent → resource → recent → file group order after #56 reordered the TUI, the legacy web prompt, and the codev run footer. Delegate the contextList grouping to a fork-only at-options module ranking recent → file → reference → agent → resource. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
quickbeard
added a commit
that referenced
this pull request
Aug 22, 2026
* fix(app): search for files on a bare @ in the composer menu #289 reordered the @ menu's groups so files lead, but the resolver short-circuited an empty query to the fixed entries plus open tabs and never searched — so with no tabs open the menu held no files to order, which is what users saw. Search on every query. Also drop fff's worktree-root entry, which an empty query now surfaces as a leading bare '/' that names no file; the ripgrep fallback never emitted it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: correct the PR link for the @ menu fix Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR #56 reordered the
@mention autocomplete so file/directory results come first — in the TUI, the legacy web prompt input, and thecodev runfooter. It missed the V2 composer (packages/session-ui/src/v2/components/prompt-input/), which is the prompt the desktop app (and the web app, now that the legacy layout is retired) actually renders — so those surfaces still listed references, agents, and MCP resources ahead of files.This applies the same ordering there: the
contextListgrouping ininteraction.tsnow delegates to a fork-onlyat-options.tsmodule ranking recent → file → reference → agent → resource (previously reference → agent → resource → recent → file).Mirrors PR #56's approach in
packages/app(fork-onlyprompt-input/at-options.ts): a minimal two-line edit to the upstream file, with the ranking and its unit test in fork-only files. The grouped menu scrolls, so no row-reserve logic is needed (unlike the TUI/run-footer variants), and default selection stays index 0 — Enter now accepts the top file match.DIVERGENCES.md row added for the
interaction.tsedit.Verification
bun typecheckclean inpackages/session-uiandpackages/app.bun test srcinpackages/session-ui: 77 pass (includes the newat-options.test.ts).🤖 Generated with Claude Code