Repository navigation
test(desktop): run the desktop test suite in CI - #297
Merged
Merged
Conversation
The package shipped 21 test files and no `test` script, so `bun turbo test` skipped it entirely: 126 passing tests that gated nothing. Add the script (scoped to `src`, like `@opencode-ai/ui`, so the built `out/` tree is never scanned) and register the matching turbo task — CI only runs test tasks declared in turbo.json, so the script alone would not have been enough. No `^build` dependency: the workspace packages the tests import (`@codev/sandbox`, `@codev/gateway`, `@opencode-ai/app` types) all export TypeScript source. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
quickbeard
force-pushed
the
desktop-test-ci
branch
from
August 22, 2026 10:46
8726e55 to
fbfae7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
packages/desktopships 21 test files — updater controller, window registry, store writer, WSL install bundle, sandbox workspace/gateway-models, attachment picker, and more — and none of them have ever run in CI. The package has notestscript, sobun turbo testintest.ymlskipped it outright: 126 passing tests gating nothing.packages/desktop/package.json: add"test": "bun test src --only-failures". Scoped tosrc(matching@opencode-ai/ui) so the builtout/tree is never scanned.turbo.json: register@opencode-ai/desktop#test. CI only runs test tasks declared here, so the script alone would not have enrolled the package. No^builddependency — the workspace packages the tests import (@codev/sandbox,@codev/gateway,@opencode-ai/apptypes) all export TypeScript source, same as the existing@codev/sandbox#testentry.DIVERGENCES.md: a row for the newpackage.jsonscript, and the existingturbo.jsonrow extended to cover both fork-added tasks.Verification
bun run testfrompackages/desktop: 126 pass / 0 fail across 21 files (~0.4s).bun turbo test --filter=@opencode-ai/desktop: 1 successful.bun turbo test --dry=jsonnow lists@opencode-ai/desktop#testin the full graph.The unit job is a linux + windows matrix, so these tests will now also run on Windows. They are written host-agnostically — the platform-shaped cases (
sandbox/workspace.test.ts,wsl/*) passplatformexplicitly and usetmpdir()/joinfor real filesystem work, and the rest are pure string/logic tests. That said, this PR's own CI run onwindows-latestis the first actual evidence.