Repository navigation
feat(app): say what a sandbox is, and stop asking for an image outside dev - #304
Merged
Merged
Conversation
…e dev The setup dialog Work opens when there is no sandbox described the download and the wait but never why any of it was happening. It now leads with what the sandbox is and what its isolation buys: the agent reaches only the folders you mount into it. The optional custom-image field is gated to dev builds. Supplying an unpublished image is how a sandbox build gets tried before release; beta and prod users can only get the published one, so the field was a question with a single answer. Gated in the shared field rather than at the two call sites, so neither create dialog can forget it. Windows 10 22H2 no longer warns that sandbox support "is not fully verified" — it has been run there and works. Builds below 22H2 keep the out-of-support warning. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three changes to the sandbox create dialogs, from testing feedback.
sandbox.addDefault.introsaid what the setup does (downloads an image, takes minutes) but never why: it now leads with what the sandbox is and what its isolation buys — the agent reaches only the folders you mount into it, so it can install packages and run commands without touching the rest of the computer. Spanish updated to match.VITE_CODEV_CHANNELinside the sharedcreateSandboxImageFieldrather than at the two call sites, so neither dialog can forget it — with the field hidden the path stays empty, which is the "download the published image" path both dialogs already take. Hides it in the full Settings → Servers dialog too.WINDOWS_10_WARNINGis gone: Windows 10 22H2 has been tested and the sandbox works there, so builds ≥ 19045 now get the same silence Windows 11 does. Builds below 22H2 keepWINDOWS_OLD_WARNING, and the WSL-installer minimum-build warning is untouched.Notes
i18n/{en,es}.ts, whosesandbox.addDefault.*keys are already covered by the "One-click sandbox for Work" row in DIVERGENCES.md — no new row needed.CHANGELOG.mdgains two Unreleased entries under Sandbox.Test plan
bun testinpackages/codev-sandbox(168 pass) — policy and WSL provider tests updated for the dropped Windows 10 tier.bun run test:unitinpackages/app(695 pass).bun typecheckinpackages/app,packages/desktop,packages/codev-sandbox.🤖 Generated with Claude Code