Repository navigation
feat(app): show Work by default, with an opt-out - #318
Merged
Merged
Conversation
The Show Work preference shipped off, which hid the Code/Work strip for any profile that had never made a sandbox. That also hides the only evidence that sandboxes exist, so the profile most likely to lose the strip is the one that would then never discover the feature — and it silently changes the sidebar for every existing install. Default it on. The gate is unchanged and still does its job: turning Show Work off puts both the Work side and the strip away until a sandbox exists, which makes hiding Work a choice rather than something that happens to you. Description reworded to match — the meaningful action is now turning the switch off, so it says what off does instead of restating that a sandbox shows Work. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #292 (
feat/work-side-opt-in), which added thegeneral.showWorkpreference and shipped it off — hiding the Code/Work strip for any profile that had never made a sandbox. This flips the default to on.Why
The gate is worth having: a desktop profile that does not use sandboxes pays for the strip anyway, with a Work side that has nothing in it and offers to build one. Letting that profile put both away is right.
Shipping it off is the part that does not hold up:
On by default keeps the app as it is and makes putting Work away an explicit choice.
What changed
settings.tsx:showWorkdefaultfalse→true.en/es/vi: the description said "Creating a sandbox shows Work either way", which reads as a caveat on an opt-in reveal. With the switch on by default the meaningful action is turning it off, so it now says what off does: "Keep the Code/Work tabs visible even with no sandboxes. Turn it off and Work stays hidden until you create one."settings.tsx,settings-v2/general.tsx,workspace/side.tsandworkspace/tabs.tsxthat asserted "sandboxes are opt-in, a profile with none has no Work side" — no longer true unless the user opts out.CHANGELOG.md: feat(app): hide the Work side until a sandbox exists #292's entry is still unreleased, so it is rewritten to describe what actually ships rather than stacking a contradicting entry after it. Both PRs are credited.DIVERGENCES.md: row retitled (it is opt-out now), default corrected, rationale replaced,vi.tsadded to the file list, and the on-conflict guidance gains "keep the defaulttrue".No logic changed:
workSideAvailable()and its four branches are untouched, and the tests pass explicitpreferencevalues, so they cover both defaults as they stand.Testing
packages/app: 700 unit + 130 browser tests pass,bun typecheckclean. No e2e spec references the strip or the preference.Docs PR: quickbeard/codev-landing-page (follows).
🤖 Generated with Claude Code