Repository navigation
feat(desktop): show live download progress for app updates - #336
Merged
Merged
Conversation
The downloading state carries a whole-number percent now: the updater controller gains reportDownloadProgress (floored, downloading-only, and deduped per whole percent so chunk-level events do not fan out to every window), fed from electron-updater's download-progress event. The update dialog renders it as a progress circle and also opens while a download is running, so an automatic download in flight is visible instead of silent until ready. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Downloading an app update used to show nothing measurable: the update dialog's button spun, the settings row said "Downloading...", and an automatic background download showed nothing at all until Install and restart appeared. On the fleet's metered links, where installers are hundreds of megabytes, that reads as a hang.
UpdaterState'sdownloadingnow actually carries thepercentthe type always declared: the controller gainsreportDownloadProgress(percent)— floored to whole percents and deduped, since electron-updater reports every chunk and each transition is a log line plus an IPC send to every window; trailing events after the download settles are ignored so they cannot resurrect the state.main/updater.tsfeeds it fromautoUpdater.on("download-progress"); the percent rides the existingupdater-statebroadcast, so no new IPC channels.available/ready, so a default-settings launch check that went straight to downloading surfaced nothing.Bookkeeping
DIVERGENCES.md(upstream files:updater-controller.ts,updater.ts, i18n en/es).🤖 Generated with Claude Code