Repository navigation
feat(app): show the sign-in URL in the desktop SSO dialog - #356
Merged
Merged
Conversation
The SSO step offered Open login page and Copy link but never showed the URL itself, so there was nothing to read, select, or check the copy against — and when the browser could not open on this machine, Copy link was a blind promise. Print it above the buttons, wrapped rather than truncated (a clipped authorize URL is unusable) and selectable, matching the TUI's SSO step, which has always printed the link. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PigpsjvQ6U8LqLbR7gYCZR
quickbeard
force-pushed
the
show-sso-link
branch
from
September 10, 2026 10:41
e5bd289 to
47b124f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The desktop Login with SSO step offered Open login page and Copy link but never showed the URL those buttons act on. The link is now printed above them — wrapped rather than truncated, in mono, and selectable.
Why
Nothing on that screen told you where you were being sent, and there was no way to check what Copy link had put on the clipboard. When the browser cannot open on this machine — no default browser, an RDP/SSH session, a VM — the paste-back field right below is the intended fallback, but its other half was invisible: you could not read the URL across to a phone or another machine to complete the sign-in there.
The TUI's SSO step has always printed the link (
packages/tui/src/component/dialog-configure.tsx); this brings the desktop dialog to parity.Changes
packages/app/src/components/gateway/dialog-configure.tsx— renderssoState().authUrlastext-12-mono … break-allin a bordered box between the "complete the login" line and the button row.packages/app/src/i18n/{en,es,vi}.ts—gateway.configure.sso.pendingreworded to end in a colon, since a link now follows it.CHANGELOG.md— user-facing entry under Gateway.No
DIVERGENCES.mdrow:components/gateway/dialog-configure.tsxis fork-only,vi.tsis fork-only, and thegateway.configure.*family inen/es.tsis already covered by its existing row.Testing
bun typecheckinpackages/app— clean.bun test src/i18ninpackages/app— 9 pass.prettier --checkon the changed files — clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01PigpsjvQ6U8LqLbR7gYCZR