Repository navigation
fix(desktop): re-check the update feed after an update is postponed - #369
Merged
Merged
Conversation
A check from the `available` state returned the known version without asking the feed, so once the user answered Later the ten-minute timer could never find a newer release until relaunch. The controller now re-asks the feed from `available`: a newer version replaces the known one, a withdrawn one lands on up-to-date, and a re-check that fails keeps the known version rather than withdrawing it. The launch prompt tracks the version it asked about instead of a once-per-run flag, so the newer release is announced too. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createUpdaterController.check()no longer returns early while the state isavailable. It asks the feed again: a newer version replaces the known one, a withdrawn one lands onup-to-date, and a re-check that fails keeps the known version rather than withdrawing it toerror(the ten-minute timer would otherwise erase a known update over a blip in the feed).UpdatePrompttracks the version it asked about instead of a once-per-run boolean, so a newer release found after Later is announced the same way the first one was.DIVERGENCES.mdrows for the update controls and the launch prompt are updated;CHANGELOG.mdgets an Unreleased entry under Desktop.Why
Answering Later to an update left the app holding on to that version: every later check, including the periodic one, came back with the same answer without asking the feed, so a release published while the app stayed open was invisible until the next relaunch.
Verification
bun test src/main/updater-controller.test.tsinpackages/desktop: 22 pass.bun typecheckinpackages/desktopandpackages/app: clean.bun run test:unitinpackages/app: 823 pass.🤖 Generated with Claude Code