Repository navigation
chore(app): remove the tabs promo popup and its 13MB video - #47
Merged
Merged
Conversation
TabsInfoPopup was upstream's temporary, dev-channel-only 'Introducing Tabs' promo, already unmounted from both layouts in this fork. Remove the component definition, the introducing-tabs.mp4 import, and the assets/help directory (the unreferenced placeholder.png included), and update the DIVERGENCES.md rows accordingly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TabsInfoPopupfromhelp-button.tsx— upstream's temporary, dev-channel-only, OpenCode-branded "Introducing Tabs" promo (upstream's own comment marks it removable after the rollout). It was already unmounted from both layouts in this fork, so this deletes only dead code;HelpButtonstays.packages/app/src/assets/help/:introducing-tabs.mp4(13 MB, only consumer was the removed popup) andplaceholder.png(referenced by nothing).DIVERGENCES.md: revise the layouts row (its "leavehelp-button.tsxuntouched" strategy is superseded) and add rows for thehelp-button.tsxedit and the asset deletion, with retirement noted for when upstream drops the popup itself.Verification
bun typecheckpasses inpackages/app; full turbo typecheck runs green on push.TabsInfoPopup,introducing-tabs, orassets/helpanywhere in the repo.showPopoveroxlint warning inhelp-button.tsxis pre-existing upstream code, left as-is.🤖 Generated with Claude Code