Repository navigation
test(tui): cover hidden LSP sidebar section (#53) - #58
Closed
quickbeard wants to merge 2 commits into
Closed
quickbeard wants to merge 2 commits into
quickbeard wants to merge 2 commits into
Conversation
Export the sidebar LSP View and add a render test asserting the whole section is hidden when config.lsp is disabled, and that the heading, empty state, and connected servers render when enabled. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a unit test for the sidebar change in #53 (hide the disabled LSP section and move the path to the sidebar bottom).
The
Viewinpackages/tui/src/feature-plugins/sidebar/lsp.tsxis now exported so it can be rendered in isolation; no behavior change.Tests
test/feature-plugins/sidebar-lsp.test.tsxrendersViewwith a stub plugin API and asserts:config.lspis disabled, the whole section is gone — noLSPheading at all (the PR's core change: no more "LSPs are disabled" placeholder).LSPheading and the "LSPs will activate as files are read" empty state render.Verification
bun test test/feature-plugins/sidebar-lsp.test.tsx— 3 pass.bun typecheckinpackages/tui— clean.🤖 Generated with Claude Code