Repository navigation
test(tui): cover home hint placement alignment (#55) - #59
Merged
Merged
Conversation
Export the which-key HomeHint and add a render test asserting the home_bottom hint left-aligns when placement is "start" (the top-left session banner) and stays centered by default (the home route). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a unit test for the placement threading introduced in #55 (flow transcript with a top-left banner). The
home_bottomslot props gainedplacement?: "center" | "start", and the session banner passesplacement="start"to left-align the hint under the logo while the home route keeps the centered layout.The which-key
HomeHintis now exported so its placement-driven alignment can be rendered in isolation; no behavior change.Tests
test/feature-plugins/which-key-home-hint.test.tsxrendersHomeHintinside a keymap provider and measures the hint line's left indentation in the captured frame:placement="start"→ the hint sits at column 0 (left-aligned, as under the session banner).Verification
bun test test/feature-plugins/which-key-home-hint.test.tsx— 2 pass.bun typecheckinpackages/tui— clean.🤖 Generated with Claude Code