Skip to content

docs: clarify db filename nuance in Internal names bullet - #93

Merged
quickbeard merged 2 commits into
mainfrom
internal-names-nuance
Jul 15, 2026
Merged

quickbeard merged 2 commits into
mainfrom
internal-names-nuance

Conversation

@quickbeard

@quickbeard quickbeard commented Jul 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

Follow-ups from the Internal names audit of DIVERGENCES.md → Known rebrand gaps:

  • The bullet's example opencode-local.db is the source-run database filename, while released builds write opencode.db. The bullet now states both — opencode.db for release channels, opencode-<channel>.db (e.g. opencode-local.db) when running from source — with a pointer to the logic in core/src/database/database.ts:53-54.
  • Dropped the "(Env vars were originally in this bucket; that decision was reversed…)" parenthetical: it documents a resolved decision, not a current gap, and the reversal plus the operative guidance ("rename any new upstream OPENCODE_* env var when syncing") already live in the env-var rename table row where they're actually consulted.

Doc-only changes to DIVERGENCES.md; no code touched.

🤖 Generated with Claude Code

quickbeard and others added 2 commits July 15, 2026 09:11
Name opencode.db as the released-build database file and show the
opencode-<channel>.db pattern that produces opencode-local.db on
source runs, with a pointer to core/src/database/database.ts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The reversal is already documented where it's actionable — the env-var
rename row's Why and On-conflict columns; the gaps section should
describe current state only.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@quickbeard
quickbeard merged commit da93d9e into main Jul 15, 2026
3 of 5 checks passed
@quickbeard
quickbeard deleted the internal-names-nuance branch July 15, 2026 02:23
quickbeard added a commit that referenced this pull request Jul 15, 2026
* test: update attention default-title expectations to codev

PR #92 renamed the OS-notification fallback title from "opencode" to
"codev" but missed the three default-title assertions in
attention.test.ts (they live under packages/opencode/test, not
packages/tui/test), failing unit (linux) on PRs #92 and #93. The
explicit-title pass-through fixture stays "opencode".

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* minor changes

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant