Repository navigation
Conversation
… classes for FprinntManager and FprintDevice
Author
|
Forgot to add a changelog entry, will do tmr maybe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds support for the Fprint daemon through
FprintManagerandFprintDevices. Through the devices you can list the enrolled fingers, enroll new ones, delete existing ones and you can start finger validation (e.g. for polkit agents & session locks).Details and descisions
(Details and decisions* btw)
For the implementation, I tried to be as close to the spec file on freedesktop's website while maintaining the vibe of other existing services. I kept the name
FprintManagerfor the service singleton, as it is that way with DBus, may change it toFprint. It may look obvious that I was using theUPowerservice as guidelines, it is my first time using Qt. All the code and documentation is written by me, no AI was used to write whatsoever, nor to understand any concept. (just no LLM at all)Open concerns
The areas where I am uncertain and open for discussion are with finger names and error handling. I feel like an enum for finger names would be better fitted and more convenient, but I haven't seen any string enums in the code. And I would love feedback on the overall code quality.
Participation
This is not a drive-by, I truly am motivated to contribute further where I can. I fully understand my code and I needed this.