Repository navigation
Match the hourly chart legends to what is drawn - #4824
Merged
Merged
Conversation
louispt1
approved these changes
Oct 1, 2026
louispt1
left a comment
louispt1
left a comment
Member
There was a problem hiding this comment.
LGTM code wise, I did not check functionally 👍
Five chart views drop series from the legend when all their values are zero, but their red target line is drawn even when empty, therefore the legend for the target line should not be droped. It is now exempt from the filter (as it already was in category_bar and StackedBar). The heat demand and production chart had the reverse problem. "Deficit" and "Buffering and time-shifting"(Surplus) label two areas derived in dataForChart rather than real series, and were added always to the legend even when empty. They are now filtered on the values dataForChart computes for them. Related to #3839 Closes #4816
aaccensi
force-pushed
the
always-show-target-line-legend
branch
from
October 5, 2026 09:32
d9eec8e to
c0f895a
Compare
Member
|
Now also functionally checked - LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Five chart views drop series from the legend when all their values are zero, but their red target line is drawn even when empty, therefore the legend for the target line should not be dropped.
Implemented changes
The legend for the target line is now exempt from the filter (as it already was in category_bar and StackedBar).
Additionally, the heat demand and production chart had the reverse problem. "Deficit" and "Buffering and time-shifting"(named "Surplus" internally) label two areas derived in dataForChart rather than real series, and were added always to the legend even when empty. They are now filtered on the values dataForChart computes for them.
Related
Actually related to issue #3839
But closes issue #4816
Checklist