Repository navigation
Add hydrogen input for methanol production (in external model liquid fuels). - #3492
Merged
Merged
Conversation
Merged
2 of 3 tasks
mabijkerk
reviewed
Sep 25, 2026
| @@ -0,0 +1,12 @@ | |||
| # Priority is set at 2 to go before the regular liquid fuels inputs | |||
|
|
|||
| - query = UPDATE(INPUT_SLOTS(V(energy_production_methanol_synthesis_non_biogenic_waste_ccs), non_biogenic_waste), conversion, DIVIDE(USER_INPUT(),100.0)) | |||
Member
There was a problem hiding this comment.
The input is getting a bit long for a single line. I think it is better to space it out a bit more:
- query =
UPDATE(
INPUT_SLOTS(...
mabijkerk
approved these changes
Oct 2, 2026
mabijkerk
left a comment
mabijkerk
left a comment
Member
There was a problem hiding this comment.
There were only some missing rows in the Sankey data export. I added those. All good now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The possibility of adding hydrogen as an input of methanol synthesis should be included in the external model for liquid fuels. In the front end this means that the share of hydrogen can be set, in addition to the input of dry biomass, biogenic waste, or non-biogenic waste.
Implemented changes
Adjust the 3 original nodes of the following processes to include hydrogen input:
Add 3 inputs for hydrogen share for the same processes.
Add inputs for dry biomass share, biogenic waste share and non-biogenic waste share.
Create a new node for non-biogenic waste as is needed for the primary emissions method:
energy_production_methanol_synthesis_non_biogenic_waste_ccsandenergy_hydrogen_after_distributionFor dry biomass and biogenic waste, add the edges connected to
energy_hydrogen_after_distribution.Related
Goes with pull requests 4817
Checklist