Repository navigation
Make the Kubernetes PostgreSQL demo explicitly TLS-disabled - #2693
nellshamrell wants to merge 4 commits into
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Nell Shamrell-Harrington <nells@microsoft.com>
Reuse the K3D local-image and Playwright paths, protect password inputs, and assert recipe identity, rollout, transport, authentication, and persisted HTTP CRUD. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Nell Shamrell-Harrington <nells@microsoft.com>
Do not equate the actual deployment namespace with the configured environment namespace; retain application labels and environment identity checks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Nell Shamrell-Harrington <nells@microsoft.com>
Fail BCP036 and BCP037 for the demo tls property even when Bicep exits successfully with a warning. Preserve unrelated warning behavior and run focused standard-library fixtures in existing validation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Nell Shamrell-Harrington <nells@microsoft.com>
1062783 to
41a0b7a
Compare
|
Final readiness-fix verification for
No repository variables, merges, workflow dispatches, or public publications were performed. The PR remains draft pending compatible publication/adoption and full acceptance. |
|
Additional verified adoption dependency from the coordinated Radius investigation: Radius currently selects The normal adoption path requires a separately approved Radius.Data namespace release containing the fix, followed by the generated Radius update PR, its reviewed merge, and verification of the resulting public Bicep extension and registered runtime schema. No release is authorized by this samples work. The reviewed recipe variables remain unconfigured and the gates remain blocked. Public compile-time schema, registered runtime schema, and the effective recipe pack are separate acceptance gates. The edge chart's |
Summary
Set the PostgreSQL demo to
tls: 'disabled'andPGSSLMODE=disablefor disposable, private Kubernetes environments. Preserve password authentication, the password Secret and existing connections.Add one PostgreSQL CI case that checks recipe identity, plaintext transport, password enforcement and persisted CRUD before running the existing Playwright tests. Make Bicep validation reject unsupported
tlsdiagnostics for this sample, even when the compiler exits successfully with a warning.Reason for change
The certificate-free demo must explicitly disable TLS before adopting recipes that enforce it by default. The resource default remains
required;optionalstill needs certificates. The guarded Azure PostgreSQL recipe rejectsdisabled.Depends on radius-project/resource-types-contrib#394.
Do not merge yet. The public extension tested in CI rejects
disabled, and the PostgreSQL job fails at the artifact gate. Compatible schemas and recipes must be published and adopted before maintainers setPOSTGRESQL_DISABLED_RECIPE_SOURCEandPOSTGRESQL_DISABLED_RECIPE_DIGESTto reviewed values. These variables verify the selected recipe; they do not publish or select it.This PR targets
edge, notv0.61. It does not change the client or image publisher. Merging toedgetriggers publication of all six sample images through the existing workflow, so approval must cover that side effect.How to test
Recorded results for head
41a0b7a:python -m unittest discover -s .github/scripts -p test_validate_bicep.pypython ./.github/scripts/validate_bicep.pytls: 'disabled'. The validator now correctly treats this unsupported value as a failure.After compatible artifacts are adopted, require the PostgreSQL job to pass its runtime checks and Playwright tests. Earlier direct-Docker probes passed, but they do not prove Radius deployment works. Test the published demo image separately with the compatible Radius artifacts; after merge, verify the tutorial against the newly published image.
File change summary
samples/demo/app-postgresql.bicepsamples/demo/README.md.github/workflows/test.yaml.github/scripts/check-postgresql-disabled.mjs.github/scripts/probe-postgresql-disabled.cjs.github/scripts/validate_bicep.pytlsdiagnostics for this sample; leave unrelated warnings unchanged..github/scripts/test_validate_bicep.py.github/workflows/validate-bicep.yaml