Skip to content

fix: skip docs build/publish on pull_request, not just push #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petercorke wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

fix: skip docs build/publish on pull_request, not just push #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,12 @@ jobs:
file: ./coverage.xml
sphinx:
# If the above worked:
# Build docs and upload to GH Pages
# Build docs and upload to GH Pages -- only on push (merge to master/future),
# never on pull_request: a PR whose branch lives in a fork (including the
# author's own fork) gets a read-only GITHUB_TOKEN by GitHub's own design,
# so the gh-pages push step always fails there regardless of repo settings.
# Publishing unreviewed PR content to the live docs site isn't desired
# either way.
needs: unittest
if: ${{ github.event_name != 'pull_request' }}
uses: ./.github/workflows/sphinx.yml
1 change: 0 additions & 1 deletion .github/workflows/sphinx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ on:
jobs:
sphinx:
runs-on: ubuntu-22.04
# if: ${{ github.event_name != 'pull_request' }}
steps:
- uses: actions/checkout@v4
- name: Set up Python 3.12
Expand Down
Loading