Repository navigation
#383 Use shared subscription names from rmg-translate - #384
Open
thekingofcity wants to merge 1 commit into
Open
thekingofcity wants to merge 1 commit into
thekingofcity wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RMT and RMP maintained separate translations for the same subscriptions. Use the full subscription names supplied by
@railmapgen/rmg-translate@3.5.3and remove the duplicated entries from all five RMT locale files. The existing account subscription labels stay the same.The shared package also provides short names for RMP badges. Its release is available on npm: railmapgen/rmg-translate#5. RMP integration: railmapgen/rmp#1599.
Validation:
npx tsc --noEmit— passed.npm run lint— passed.CI=true npm test -- --maxWorkers=4— 10 test files and 46 tests passed.npm run build— passed.Closes #383