Repository navigation
Support native contexts and verified SSH in the packaged API - #163
Conversation
pparage
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a184af6119
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| environment = { | ||
| # Context files can select CLI defaults; restore the API's verified | ||
| # connection policy after sourcing them and before running Ansible. | ||
| "ANSIBLE_HOST_KEY_CHECKING": "True", |
There was a problem hiding this comment.
When a native shell action invokes ssh directly and its rendered/copied SSH config contains StrictHostKeyChecking no, this export does not protect the connection: ANSIBLE_HOST_KEY_CHECKING is an Ansible-specific setting, while the PATH wrapper below executes OpenSSH with only -F <config>. OpenSSH therefore uses the unsafe config value—its documented precedence gives command-line options priority and otherwise uses the first configured value—allowing the action to trust an unverified host despite the packaged API policy. Add an explicit -o StrictHostKeyChecking=yes and the verified known-hosts file to the wrapper/common SSH arguments.
Useful? React with 👍 / 👎.
Run native contexts without rewriting the read-only runtime, retain verified SSH pins, and recognize the reviewed installer bundles. VM operations and the multi-member SDN guard remain unchanged.
Validation: 22 runtime-contract tests and 96 focused security tests passed, including unknown-tree rejection and multi-member refusal; Ruff passed. Use with the matching core, playbooks and catalog fixes.