Skip to content

chore: upgrade biome to 2.6.7 #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Naturalclar merged 3 commits into from
Nov 15, 2026
Merged

chore: upgrade biome to 2.6.7 #1254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
202e665
chore: upgrade biome to 2.6.7
Naturalclar Nov 15, 2026
517bba3
chore: scope the codegen deep-import suppression to the import block
Naturalclar Nov 15, 2026
38f8368
fix(android): import codegenNativeCommands from react-native's public…
Naturalclar Nov 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,24 @@
{
"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
"$schema": "https://biomejs.dev/schemas/2.6.7/schema.json",
"vcs": {
"enabled": false,
"clientKind": "git",
"useIgnoreFile": false
},
"files": {
"ignoreUnknown": false,
"ignore": ["lib"]
"includes": ["**", "!**/lib"]
},
"formatter": {
"enabled": true,
"indentStyle": "tab"
},
"organizeImports": {
"enabled": true
"indentStyle": "tab",
"includes": ["**", "!**/*.md", "!**/*.yml", "!**/*.yaml"]
},
"assist": { "actions": { "source": { "organizeImports": "on" } } },
"linter": {
"enabled": true,
"rules": {
"recommended": true
"preset": "recommended"
}
},
"javascript": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
},
"homepage": "https://github.com/react-native-menu/menu#readme",
"devDependencies": {
"@biomejs/biome": "1.9.4",
"@biomejs/biome": "2.6.7",
"@callstack/react-native-visionos": "^0.79.6",
"@react-native-community/cli": "^20.0.2",
"@react-native/babel-preset": "^0.81.1",
Expand Down
2 changes: 1 addition & 1 deletion react-native.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const project = (() => {
sourceDir: path.join("example", "ios"),
},
});
} catch (e) {
} catch {
return undefined;
}
})();
Expand Down
7 changes: 7 additions & 0 deletions src/NativeModuleSpecs/UIMenuNativeComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
// biome-ignore-start lint/suspicious/noReactNativeDeepImports: this is a codegen spec file.
// React Native's codegen parses these imports directly and expects CodegenTypes and
// codegenNativeComponent on these exact paths. react-native/index.js does re-export
// codegenNativeComponent, but rewriting an import that codegen parses risks breaking native
// builds for no benefit -- see the note on this file in CLAUDE.md. Scoped to this import
// block rather than the whole file, so accidental deep imports below are still caught.
import type {
DirectEventHandler,
Int32,
WithDefault
} from "react-native/Libraries/Types/CodegenTypes";
import type { HostComponent, ViewProps } from "react-native";
import codegenNativeComponent from "react-native/Libraries/Utilities/codegenNativeComponent";
// biome-ignore-end lint/suspicious/noReactNativeDeepImports: end of the codegen import block.

/*
Caution, those below are not just typescript types.
Expand Down
2 changes: 1 addition & 1 deletion src/UIMenuView.android.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import {
codegenNativeCommands,
findNodeHandle,
type HostComponent,
requireNativeComponent,
UIManager,
} from "react-native";
import type { MenuComponentRef, NativeMenuComponentProps } from "./types";
import { forwardRef, useImperativeHandle, useRef } from "react";
import codegenNativeCommands from "react-native/Libraries/Utilities/codegenNativeCommands";

const NativeMenuComponent = requireNativeComponent(
"MenuView",
Expand Down
96 changes: 58 additions & 38 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3415,19 +3415,25 @@ __metadata:
languageName: node
linkType: hard

"@biomejs/biome@npm:1.9.4":
version: 1.9.4
resolution: "@biomejs/biome@npm:1.9.4"
dependencies:
"@biomejs/cli-darwin-arm64": "npm:1.9.4"
"@biomejs/cli-darwin-x64": "npm:1.9.4"
"@biomejs/cli-linux-arm64": "npm:1.9.4"
"@biomejs/cli-linux-arm64-musl": "npm:1.9.4"
"@biomejs/cli-linux-x64": "npm:1.9.4"
"@biomejs/cli-linux-x64-musl": "npm:1.9.4"
"@biomejs/cli-win32-arm64": "npm:1.9.4"
"@biomejs/cli-win32-x64": "npm:1.9.4"
"@biomejs/biome@npm:2.6.7":
version: 2.6.7
resolution: "@biomejs/biome@npm:2.6.7"
dependencies:
"@biomejs/cli-android-arm64": "npm:2.6.7"
"@biomejs/cli-android-x64": "npm:2.6.7"
"@biomejs/cli-darwin-arm64": "npm:2.6.7"
"@biomejs/cli-darwin-x64": "npm:2.6.7"
"@biomejs/cli-linux-arm64": "npm:2.6.7"
"@biomejs/cli-linux-arm64-musl": "npm:2.6.7"
"@biomejs/cli-linux-x64": "npm:2.6.7"
"@biomejs/cli-linux-x64-musl": "npm:2.6.7"
"@biomejs/cli-win32-arm64": "npm:2.6.7"
"@biomejs/cli-win32-x64": "npm:2.6.7"
dependenciesMeta:
"@biomejs/cli-android-arm64":
optional: true
"@biomejs/cli-android-x64":
optional: true
"@biomejs/cli-darwin-arm64":
optional: true
"@biomejs/cli-darwin-x64":
Expand All @@ -3446,62 +3452,76 @@ __metadata:
optional: true
bin:
biome: bin/biome
checksum: 10c0/b5655c5aed9a6fffe24f7d04f15ba4444389d0e891c9ed9106fab7388ac9b4be63185852cc2a937b22940dac3e550b71032a4afd306925cfea436c33e5646b3e
checksum: 10c0/2ad0a8076ce352386dd14f6170eb1ddd8e9ef5b21d6b195a0b92e0a0216b541b85d51eb41432767d00f756c20c47960ca50c475369626117c9e4dc4d12174f91
languageName: node
linkType: hard

"@biomejs/cli-android-arm64@npm:2.6.7":
version: 2.6.7
resolution: "@biomejs/cli-android-arm64@npm:2.6.7"
conditions: os=android & cpu=arm64
languageName: node
linkType: hard

"@biomejs/cli-android-x64@npm:2.6.7":
version: 2.6.7
resolution: "@biomejs/cli-android-x64@npm:2.6.7"
conditions: os=android & cpu=x64
languageName: node
linkType: hard

"@biomejs/cli-darwin-arm64@npm:1.9.4":
version: 1.9.4
resolution: "@biomejs/cli-darwin-arm64@npm:1.9.4"
"@biomejs/cli-darwin-arm64@npm:2.6.7":
version: 2.6.7
resolution: "@biomejs/cli-darwin-arm64@npm:2.6.7"
conditions: os=darwin & cpu=arm64
languageName: node
linkType: hard

"@biomejs/cli-darwin-x64@npm:1.9.4":
version: 1.9.4
resolution: "@biomejs/cli-darwin-x64@npm:1.9.4"
"@biomejs/cli-darwin-x64@npm:2.6.7":
version: 2.6.7
resolution: "@biomejs/cli-darwin-x64@npm:2.6.7"
conditions: os=darwin & cpu=x64
languageName: node
linkType: hard

"@biomejs/cli-linux-arm64-musl@npm:1.9.4":
version: 1.9.4
resolution: "@biomejs/cli-linux-arm64-musl@npm:1.9.4"
"@biomejs/cli-linux-arm64-musl@npm:2.6.7":
version: 2.6.7
resolution: "@biomejs/cli-linux-arm64-musl@npm:2.6.7"
conditions: os=linux & cpu=arm64 & libc=musl
languageName: node
linkType: hard

"@biomejs/cli-linux-arm64@npm:1.9.4":
version: 1.9.4
resolution: "@biomejs/cli-linux-arm64@npm:1.9.4"
"@biomejs/cli-linux-arm64@npm:2.6.7":
version: 2.6.7
resolution: "@biomejs/cli-linux-arm64@npm:2.6.7"
conditions: os=linux & cpu=arm64 & libc=glibc
languageName: node
linkType: hard

"@biomejs/cli-linux-x64-musl@npm:1.9.4":
version: 1.9.4
resolution: "@biomejs/cli-linux-x64-musl@npm:1.9.4"
"@biomejs/cli-linux-x64-musl@npm:2.6.7":
version: 2.6.7
resolution: "@biomejs/cli-linux-x64-musl@npm:2.6.7"
conditions: os=linux & cpu=x64 & libc=musl
languageName: node
linkType: hard

"@biomejs/cli-linux-x64@npm:1.9.4":
version: 1.9.4
resolution: "@biomejs/cli-linux-x64@npm:1.9.4"
"@biomejs/cli-linux-x64@npm:2.6.7":
version: 2.6.7
resolution: "@biomejs/cli-linux-x64@npm:2.6.7"
conditions: os=linux & cpu=x64 & libc=glibc
languageName: node
linkType: hard

"@biomejs/cli-win32-arm64@npm:1.9.4":
version: 1.9.4
resolution: "@biomejs/cli-win32-arm64@npm:1.9.4"
"@biomejs/cli-win32-arm64@npm:2.6.7":
version: 2.6.7
resolution: "@biomejs/cli-win32-arm64@npm:2.6.7"
conditions: os=win32 & cpu=arm64
languageName: node
linkType: hard

"@biomejs/cli-win32-x64@npm:1.9.4":
version: 1.9.4
resolution: "@biomejs/cli-win32-x64@npm:1.9.4"
"@biomejs/cli-win32-x64@npm:2.6.7":
version: 2.6.7
resolution: "@biomejs/cli-win32-x64@npm:2.6.7"
conditions: os=win32 & cpu=x64
languageName: node
linkType: hard
Expand Down Expand Up @@ -4768,7 +4788,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@react-native-menu/menu@workspace:."
dependencies:
"@biomejs/biome": "npm:1.9.4"
"@biomejs/biome": "npm:2.6.7"
"@callstack/react-native-visionos": "npm:^0.79.6"
"@react-native-community/cli": "npm:^20.0.2"
"@react-native/babel-preset": "npm:^0.81.1"
Expand Down
Loading