Repository navigation
T023: the release's 15 species, the Jenkinsfile's command, the xml:base check - #85
Closed
adamjohnwright wants to merge 1 commit into
Closed
adamjohnwright wants to merge 1 commit into
adamjohnwright wants to merge 1 commit into
Conversation
…se check -s now takes a list of species ids, each written to its own file. The Jenkinsfile passes the 15 species of release 98's published zip; whether to add Mycobacterium tuberculosis, which has events of its own but has never been published, is issue #84. The stray quote that ended its docker run line is gone. CI's fixture job now runs the release's own xml:base check (the DownloadDirectory step's grep), which passes for the fixture's release and fails for another. The command's shape was run from an image built from this branch against the private fixture graph, zipped as the Jenkinsfile does, and checked as the release checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced by #86, with this review's findings fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, T023.
-snow takes a list of species ids, each written to its own file (one id still works). The Jenkinsfile passes the 15 species of release 98's publishedbiopax.zip, read from those files' ownxml:base. Whether to add Mycobacterium tuberculosis, which has events of its own but has never been published, is Should the release's BioPAX files include Mycobacterium tuberculosis? #84. If yes, it is one more id in the Jenkinsfile.docker runline, which would have stopped the shell, is gone. The jar is the image's entry point, and-o ./outputlands in the mounted folder..owlinbiopax.zipmust holdxml:base="http://www.reactome.org/biopax/{release}. CI's fixture job now runs the same check. It passes for the fixture's release (98) and fails for another (97).--network=host, the mount,-o ./output,-swith the two species the fixture graph holds) against the private fixture graph;zip -r, and the release's check on the unzipped files: two files, both with the release's base.The release server's own run is the release's, and its timing is T024.
-s 48887,170928. A bad species id exits 1. 93 tests pass, and actionlint is clean.🤖 Generated with Claude Code