Skip to content

Spec 001, from #94's review: the authors' claim limited to the files' authors #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamjohnwright merged 1 commit into from
Oct 29, 2026
Merged

Spec 001, from #94's review: the authors' claim limited to the files' authors #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specs/001-biopax-from-graph/differences.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ Measured 29 Oct 2026 on all 15 species, from a private copy of release 98's grap
- **Why they differ:** the two writers take a Person's name from different rules.
- The release's converter wrote the relational `_displayName`. The curator tool's rule for it (`InstanceDisplayNameGenerator.generatePersonName`) puts the first name first, and the initials only when there is none.
- The graph importer does not copy a Person's `_displayName`, as it does every other class's: `ReactomeBatchImporter` rebuilds it as `surname, initial`, the first name only when there is no initial, "to fix different styles in Person display name". It has done so since its first commit (2016), so whichever commit built release 98's graph.
- So every Person in the graph has the initials form (all but one, a script's, whose display name is its own), whatever the relational database holds; it says nothing of the data. The published files do: there, every other author has the initials form too, so in release 98's relational database these 62 alone held the curator tool's first-name form.
- So every Person in the graph that came from the relational database has the initials form, whatever that database holds; it says nothing of the data. (One more Person, the interaction import's user, is made by the importer itself with its display name set as it is, `TrackingObjects.createGraphImporterUserNode`, and is not rebuilt.) The published files say something of the data, but only of the authors they name: of those, every other one has the initials form too, so among the authors in release 98's files these 62 alone held the curator tool's first-name form. People the files do not name (curators, or authors of literature no event cites) were not compared.
- **Which form is meant:** the importer normalises on purpose, and the exporter writes the graph's display name, as it should; neither is a fault here. Whether a Person's display name is meant to be the importer's `surname, initial` or the curator tool's `surname, firstname` is a question for those two tools' owners (T022). Until it is settled, the files written from the graph give these authors their initials.

## Paxtools 6, Kotlin 2.4, JUnit 6 (#66)
Expand Down
Loading