Repository navigation
Balanced variant choices (LNG_BALANCE_CHOICES, deltasignal specs/101) - #126
Merged
Merged
Conversation
…on copies whose protein content does not balance when better-balanced copies exist on both the output and the input side (MDM2 alone made MDM2:MDM4) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…0, exp -4, gate passes) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bind_output_slotsbinds an output set to an input set only when reference signatures match exactly, so a reaction like "MDM2 forms homo- or heterodimers" (R-HSA-6804741) was emitted as the full input × output cross product. Two of its four copies are unbalanced: p-MDM2 alone makes MDM2:MDM4 (creating MDM4), and MDM4 + p-MDM2 makes the MDM2 dimer (losing MDM4).balance_choices(insrc/variant_emission.py) scores each copy by the proteins its outputs gain plus the proteins its inputs lose. It drops a copy only when a lower-scoring copy exists with the same outputs AND another exists with the same input choice. So an input with no balanced partner keeps its best copy.Measured (deltasignal specs/101, registered gate as specs/077), arm
balvs canonical defaults:Structure:
Changes:
LNG_BALANCE_CHOICES, default1.PIPELINE_SETTINGS.mdrow.tests/test_variant_emission.py.Checks: full suite passes except the known stale
test_main_edges_proportional_to_best_matches[...983169], which also fails on main. mypy is clean.🤖 Generated with Claude Code