Repository navigation
Spec 001 T024: the book's preflight - #150
Closed
adamjohnwright wants to merge 4 commits into
Closed
adamjohnwright wants to merge 4 commits into
adamjohnwright wants to merge 4 commits into
Conversation
src/preflight/ checks, before anything is printed: the book's file names (bad-file-name), the release's files the figures need (missing-file), the figures' folder against the graph's release, checksum and EHLD summary (incomplete-folder, no-checksum, stale-folder, stale-summary, stale-figure, missing-file), and FR-017's characters in the texts, the reactions' figures' names and the drawn diagram files' labels (uncovered-character). `pdf-export preflight` runs it alone. The book's mode of FR-017 is BookCharacters in src/layout/characters.ts and labelsInBook in src/figures/labels.ts. The release reader gains releaseInfo with the DBInfo checksum, read as its digits, and figureNames; the fixture gains a checksum and a compartment only a participant holds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An error during the preflight is now exit 2 with the error on stderr, after the faults found before it are printed; exit 1 means faults only. A diagram file that cannot be read as JSON is a fault, bad-file <name>, and the run goes on. The start's graph read has a bounded retry of its own driver; the checks' reads keep the driver's default. The diagram files' node attachments' labels are read. Tests for a stale folder refused as a whole, a selection's length and its ids' type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced after review: an unparsable graph URI still exited 1 with no fault line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, task T024. Replaces #149 after its review (one medium, fixed in the second-last commit).
Everything in #149 (
pdf-export preflight: file names, the release's files, the figures' folder against its manifest, and FR-017's characters in the book's fault mode), plus, from #149's review:bad-file <name>and the run goes on; any other error prints the faults found so far and exits 2 with the error on stderr (contracts/cli.md updated).nodeAttachments[].label, drawn as modifications) are now read.contentnot compared bybook; case-insensitive names bytoLowerCase; unprinted strings checked; T047 needs the fingerprint comparison separately; truncated.graph.jsonnot detected; graph-side modification labels and the normal diagram under a disease diagram unchecked.Tests: 350 in all. Mutants in tasks.md.
🤖 Generated with Claude Code