Repository navigation
Spec 001 T046: the figures step - #155
Merged
Merged
Conversation
Draws the book's figures into a folder before the book: the Figure rules by the book's own code, T024's release-file and character checks before any request, the render service's health and the content release checked, each figure drawn, label-checked, written beside its name and moved into place, its manifest line appended only once the deployment reads unchanged. A figure's own fault leaves it out while the rest are drawn; a deployment changed or gone, or the breaker, stops the run at once. The client names each missing figure's cause and, for figures only, retries a 504 or a timeout once. The render stub gains 500/504, health, a hook, silence and slowness; a content stub is added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed, --report kept A figure unanswered after its retry is named and leaves no complete (and complete needs a line for every figure). An existing --report is refused first and never overwritten; the report's folder is made, it is written beside its name and renamed, and a failed write keeps the run's exit. The services are probed before the preflight and read again for the fingerprint; the silent breaker allows the retry's pause; figure files and manifest lines are written whole; the figures' faults are printed on the run's own error. Tests kill the review's surviving mutants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, task T046. Replaces #154 after its review (two mediums, fixed in the second-last commit).
Everything in #154 (
pdf-export figures: the book's figures drawn into a folder with a manifestbookchecks), plus, from #154's review:completeuntested; now tested, andcompletealso requires a manifest line for every figure.--reportcould overwrite an earlier run's report or turn a refusal into exit 1: an existing report is refused first; its folder is made; it is written beside its name and moved in; a failed write is said and keeps the run's exit. Contracts say a signal, or a refused--report, writes none.Tests: 400 in all (
test/figures/step.test.ts31). Mutants in tasks.md.🤖 Generated with Claude Code