Repository navigation
Spec 001 T029: book, end to end - #157
Closed
adamjohnwright wants to merge 4 commits into
Closed
adamjohnwright wants to merge 4 commits into
adamjohnwright wants to merge 4 commits into
Conversation
The preflight, then each top-level pathway's PDF printed in parts from the figures' folder, its contents numbered, links rewritten, outline written and pages stamped, saved with object streams off into a folder moved into place only once every PDF is written. A figure's labels are checked before its part prints; FR-017's substitutions are counted as printed; the run report is written however the run ends. The join's memory on the real book is left to T031. Folded in: a test timeout and concurrency bound, the preflight's graph open and close guarded, and stamp.ts's lows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hecked A signal is handled from the run's start and held while the browser launches, the report written naming it; an unwritable or mounted --out and an existing or unwritable --report are refused at the start; a figure file removed mid-run is a missing-file fault; and the printed PDFs are read for every substituted field and a figure's label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced after review: SIGINT during Chromium's launch bypassed the signal hold (Playwright's own handler); two printed fields' substitutions untested. |
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, task T029. Replaces #156 after its review (five mediums, fixed in the second-last commit).
Everything in #156 (
pdf-export book: preflight, figures from the folder, printing in parts, reprint, links, outline, stamps, the folder moved into place whole, the run report), plus, from #156's review:--outgave exit 1 and a stack trace after the preflight: checked at the start (exit 2).--reportpath was found only after the book was in place: refused or prepared at the start.stopwrites the report naming the signal.--outthat is a mount point is refused at the start; a figure file removed mid-run is amissing-filefault; the label check is proven to run before its part prints.Tests:
test/book/book.test.ts(14); 415 in all. Mutants in tasks.md.🤖 Generated with Claude Code