Repository navigation
Spec 001 T030: check-book - #161
Closed
adamjohnwright wants to merge 4 commits into
Closed
adamjohnwright wants to merge 4 commits into
adamjohnwright wants to merge 4 commits into
Conversation
…place pdf-export check-book <folder> reads each PDF's outline, links and text with pdf.js and reports FR-011's faults in the contract's three line forms: missing-pathway, extra-file, and per PDF not-in-contents, not-in-outline, no-name, no-stable-id, missing-figure (where the source is in --files) and broken-link. book closes its printer, runs the check on its folder and moves the folder into place only when it passes; faults are exit 1 with no book, and the run report gives each check with its count of faults. From #159's review: a test that a printer's close removes its folder; one private temporary folder live a process; bookCommand's cleanup in a finally, the report written before the folder is removed; the serve contract says which signals leave nothing; a signal once the book is in place reports it written, with the signal, and exits 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…gainst their page The layout breaks a word too long for its line anywhere, so nothing is wider than the text column and Chromium never prints a part scaled down; the check reads a heading against its page's body text, so one printed scaled down still reads its names. Names are compared without the characters never drawn. Two sections of one name are told apart by their stable identifiers, the contents list is bounded by the outline, an undecodable address is a broken link, and the names are indexed once. A failed removal of the private folder keeps its exit handler. Release 98's counts of tables in summations noted in research R8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced after review: figure labels could set a page's body size; overflow-wrap:anywhere broke ordinary words in tables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, task T030. Replaces #160 after its review (one high, one medium, fixed in the second-last commit).
Everything in #160 (
check-book, run bybookbefore the folder is moved into place), plus, from #160's review:overflow-wrap: anywhere, tables at most the column's width), tested with a wide table and a 140-character token printing at full size; and the check judges a heading's size against its page's body text, so a scaled part can't read as missing names.Tests: 439 in all. Mutants in tasks.md.
🤖 Generated with Claude Code