Repository navigation
Return private typed Context errors (supersedes #1005; Docs held) - #1215
Draft
sidneyswift wants to merge 3 commits into
Draft
sidneyswift wants to merge 3 commits into
sidneyswift wants to merge 3 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
5 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared Context HTTP and MCP operations currently collapse failures into a blanket 409 or fixed message. This candidate returns authored
code,retryableand action-awareguidanceconsistently across both transports while preserving HTTPerror, MCPmessage/success: false, and MCPisError: true.Draft and held for Docs #31 native/content acceptance and release order. Docs31 remains pinned to
b09baf719f09249e2d65b391167fcddd1df05c1b; its protected-preview/native gate is unchanged. This PR must remain unmerged until that acceptance and ordering are resolved. Legacy docs-legacy#361 does not satisfy the prerequisite. Source-only progress toward recoupable/app#2125, without hosted/account/workspace acceptance.Supersedes the bounded typed-error work of #1005. Current source includes main
f38a86bf36f9691e1e84da13725835196d9634dcthrough a normal merge retaining candidate4977dce3fe6320031bf09209d83240e85b2005deas first parent. All accepted main changes are preserved; the README retains both appended sections. Two newer ownership fixtures use the exact authored denial message with private details incause, preserving conservative unknown-error classification.Validation: 380 integrated tests pass across 14 focused suites, including typed transports/classification/published examples and the newer ownership, guest-routing and terminal-workflow regressions. Scoped TypeScript, ESLint, formatting and diff checks pass. Independent merged-source review PASS. No whole-repository typecheck or runtime acceptance claim.
All six Docs31-bound pure module files remain byte-identical to
4977dce3and match the existing Docs fixture hashes. No contract or Docs fixture changed. The Docs checker still requires exact HEAD4977dce3; this source-byte compatibility proof does not bypass that checker or satisfy native/content acceptance.Required Docs changes: current Context OpenAPI error schema and status responses; HTTP/MCP envelopes; operation-level unsupported URL descriptions (422 where applicable, retaining schema 400); conditional retry guidance; URL-only/reconnect/partial examples; explicit auth/schema exceptions, conservative stored-data classification, reserved budget status and no paid-work guarantees. Details in the pending-contract README section.
No action/schema/migration/provider implementation, database operation, build, server, browser, login, credentials or production data access. Guest endpoint behavior is unchanged. Merge and hosted qualification remain separate.
Summary by cubic
Replaces the blanket 409/fixed-message Context failures with authored
code,retryable, andguidanceerrors that are identical across HTTP and MCP, while preserving existing HTTPerror, MCPmessage/success: false, andisError: truefields.This is a source-only draft held for the owning Docs contract; legacy
docs-legacy#361does not satisfy the prerequisite and the current contract must be accepted before merging. Supersedes the typed-error work in #1005.Error contract
budget_exhaustedis reserved with no spend-path producer.internal, unknown storage rejections are opaquestorage_failed, and disabled capabilities return 503unavailablewith contract examples aligned.Written for commit 4977dce. Summary will update on new commits.