Repository navigation
Label saved catalog estimates with model provenance - #1222
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
sidneyswift
marked this pull request as ready for review
November 2, 2026 19:28
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved catalog valuations currently carry numbers and a free-text trace without structured model provenance. This adds an
estimatedescriptor containing USD currency, lifetime-average period and catalog-age/floor source, immutable assumptions, methodology version/executor and source freshness. Modeled estimates remain explicitly separate from observed revenue (not_collected), includingnot_measuredresults with null modeled-period values.The descriptor reads the existing model constants, including the one-year age floor. Constants, formulas, rounding, date behavior and existing result fields are preserved. The enrichment reuse key becomes
catalog-valuation-v2so unlabeled v1 content is not silently reused.scopeandshareableare documented labels; existing owner/catalog access checks remain the permission boundary.Validation: genuine RED before implementation (three missing-label/key failures), then 26 focused model/descriptor/collector/enrichment tests passing. Exact baseline comparison: 132 model outputs and 24 collector cases with every pre-existing field unchanged under a fixed clock. Nested assumptions are frozen. Scoped TypeScript, ESLint, Prettier and whitespace checks passed; independent source review completed.
Adapted from historical API #1018 head717a3177 onto verified main2a4f116b. No migration, HTTP/MCP action, dispatcher enablement, brief integration, provider call, paid collection, marketing/chat mirror change or commercial-assumption endorsement. Verification is source/local synthetic only, not hosted runtime, provider execution or actual revenue. Draft for root's exact-head review, CI qualification and merge.
Refs recoupable/app#2144.
Summary by cubic
Adds a structured
estimatedescriptor to saved catalog valuations so the numbers carry provenance—currency, period, assumptions, methodology, and source—instead of a free-text trace.not_collected);not_measuredresults carry null catalog-age and floor values.catalog-valuation-v2so unlabeled v1 results are not silently reused.scopeandshareableare descriptive labels only.Written for commit 3f1517a. Summary will update on new commits.