Repository navigation
test: verify guest adoption workspace routing - #1223
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
sidneyswift
marked this pull request as ready for review
November 2, 2026 20:11
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing guest-adoption routing coverage through the real handler, authentication-context validation, owner authorization and processor. Mock only credential/membership lookups and RPC/dispatch boundaries. The eight cases verify personal and organization actor/owner routing, denied/malformed scope, domain membership recheck, credential refusal, retained claim cookies, and handling of mocked expired/foreign-claimed/replay answers.
Only a new test suite and two bounded README paragraphs change. Existing guest/transport/owner/workflow tests are reused, including fresh-start capability behavior and duplicate-worker skipping. No production behavior, claim policy, destination UI, migration or attribution changes.
Validation: baseline34tests/5suites passed (not claimed as RED); a temporary wrong-owner production mutation failed the organization routing assertion, then production was restored byte-identical and all8newcases passed again. Scoped lint/format passed. Repository-settings scoped TypeScript passed; an exploratory strict=true run reported one existing transitive nullability error in unchanged canAccessAccount.ts. Independent review recorded in handoff.
Mocked RPC idempotent/rejection answers are source fixtures, not DB transaction or intended-account hosted/browser proof. Redispatching the existing guest ID does not itself prove extraction deduplication. Root owns final exact-head review/CI/merge.
Summary by cubic
Adds guest-adoption workspace routing coverage through the real handler, authentication-context validation, owner authorization, and processor, mocking only credential/membership lookups and RPC/dispatch boundaries.
guestWorkspaceRouting.test.tsverify personal and organization actor/owner routing, denied and malformed scopes never reaching private storage or dispatch, domain membership recheck, credential refusal, retained claim cookies, and mocked expired/foreign-claimed/replay answers.Written for commit 16caf0f. Summary will update on new commits.