Repository navigation
docs: align valuation history wording fixture hash - #1224
Draft
sidneyswift wants to merge 2 commits into
Draft
sidneyswift wants to merge 2 commits into
sidneyswift wants to merge 2 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coordinated Docs33 correction removes an unsupported guarantee that every valuation run persists history and corrects two account-targeting descriptions to match the already documented account_id and existing handler behavior.
Update only the releases OpenAPI source hash in lib/contracts/fixtures/published-docs.json to 6294c1dfb36539d3279a2d4ae8b1f650dfcaf81f2611f44a5dfb928c3b141e22. The full API fixture is byte-identical to the corrected Docs example fixture (SHA256 2149e39d89f7b7a9ed9b4b1170ed377032e1dc8f80d894e94b06cb1a17a8667e). Examples, schemas, authorization policy, production behavior and other hashes are unchanged.
Validation: original paired checker fails before the hash update and passes afterward; 296 existing published-fixture tests across 25 suites pass; formatting and diff checks pass. Independent review PASS. JSON metadata only.
Related to recoupable/mono#326 and recoupable/mono#360. Draft for coordinated review only. No merge, deployment, hosted validation or global Docs pin promotion. Docs owner separately assesses the full inventory delta before selecting a new global API pin. Native acceptance and release ordering remain unchanged.
Summary by cubic
Updates the published Docs fixture hash for
releases.jsonso the paired documentation-fixture checker passes after a coordinated Docs correction removed the guarantee that every valuation run persists history.No TypeScript source, contracts, or other hashes change; only the metadata entry in
lib/contracts/fixtures/published-docs.jsonis updated to match the corrected Docs source.Written for commit 1e7f426. Summary will update on new commits.