Repository navigation
docs: correct valuation history and effective account wording - #33
Draft
sidneyswift wants to merge 4 commits into
Draft
sidneyswift wants to merge 4 commits into
sidneyswift wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
sidneyswift
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /api/valuation computes an estimate without saving valuation history, and supports an authorized account_id override. Correct the contradictory history guarantee and caller-only prose: credentials authenticate first; the effective account defaults to the authenticated account or becomes the authorized override. Measurement credits and roster attachment use that effective account. Optional organization ownership checks whether the effective account is the organization itself or a member.
Only the valuation operation description and organization_id description change, alongside generated representations/source hashes and focused regressions. The account_id schema, auth/errors, operation availability and unfinished history decisions are preserved.
Refs recoupable/mono#326 (API-DOC-02) and recoupable/mono#360. Does not close the broader persistence/readback work in Mono #326, Chat #1911, API #795, or held API #1059.
Validation: both wording regressions demonstrated RED then GREEN. Latest delta passes generation, docs:check, inventory check, types, lint, 7 focused tests and 37 response-contract tests; independent source review PASS. Prior full suite/static build passed before the description-only follow-up.
Paired source dependency: inventory pin now references API #1224 head 1e7f42692fad476cf17744338b6e9412dbb26b6b. The original inventory and shared-example checkers pass against that exact candidate. The pin follow-up changes only apiSourceCommit; all operation/registration/disposition/schema/spec bindings remain identical. All 46 focused inventory, response, OpenAPI, wording and build-drift tests pass, with independent delta review PASS. Earlier fixture failures remain preserved, not erased. No API files changed here; root owns exact-head CI qualification.
Both PRs remain draft/unmerged. Source compatibility is not a release/serving claim. Root owns merge order and native acceptance. Held Docs #31/#32 and API #1215/#1216 are untouched.