Skip to content

Deprecate AddArrayResultColumnNamesRector #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 17, 2026
Merged

Deprecate AddArrayResultColumnNamesRector #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions config/sets/composer-based.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
use Rector\Doctrine\Dbal36\Rector\MethodCall\MigrateQueryBuilderResetQueryPartRector;
use Rector\Doctrine\Dbal40\Rector\MethodCall\ChangeCompositeExpressionAddMultipleWithWithRector;
use Rector\Doctrine\Dbal40\Rector\StmtsAwareInterface\ExecuteQueryParamsToBindValueRector;
use Rector\Doctrine\Dbal42\Rector\New_\AddArrayResultColumnNamesRector;
use Rector\Doctrine\DoctrineFixture\Rector\MethodCall\AddGetReferenceTypeRector;
use Rector\Doctrine\Orm214\Rector\Param\ReplaceLifecycleEventArgsByDedicatedEventArgsRector;
use Rector\Doctrine\Orm28\Rector\MethodCall\IterateToToIterableRector;
Expand Down Expand Up @@ -77,10 +76,9 @@
// doctrine/dbal 3.2
PlatformGetNameToInstanceofRector::class,

// doctrine/dbal 4.0 and 4.2
// doctrine/dbal 4.0
ChangeCompositeExpressionAddMultipleWithWithRector::class,
ExecuteQueryParamsToBindValueRector::class,
AddArrayResultColumnNamesRector::class,

// doctrine/doctrine-bundle 2.3 and 2.8
AddAnnotationToRepositoryRector::class,
Expand Down
28 changes: 0 additions & 28 deletions ...bal42/Rector/New_/AddArrayResultColumnNamesRector/AddArrayResultColumnNamesRectorTest.php
View file
Open in desktop

This file was deleted.

31 changes: 0 additions & 31 deletions ...al42/Rector/New_/AddArrayResultColumnNamesRector/Fixture/passing_new_array_result.php.inc
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions .../Dbal42/Rector/New_/AddArrayResultColumnNamesRector/Fixture/skip_already_two_args.php.inc
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions rules-tests/Dbal42/Rector/New_/AddArrayResultColumnNamesRector/config/configured_rule.php
View file
Open in desktop

This file was deleted.

5 changes: 3 additions & 2 deletions rules/Dbal42/Rector/New_/AddArrayResultColumnNamesRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use PhpParser\Node\Expr\New_;
use PhpParser\Node\Name;
use PhpParser\Node\Scalar\Int_;
use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;
use Rector\Doctrine\Enum\DoctrineClass;
use Rector\Rector\AbstractRector;
use Rector\RuleDoc\CodeSample\CodeSample;
Expand All @@ -23,9 +24,9 @@
/**
* @see https://github.com/doctrine/dbal/pull/6504/files
*
* @see \Rector\Doctrine\Tests\Dbal42\Rector\New_\AddArrayResultColumnNamesRector\AddArrayResultColumnNamesRectorTest
* @deprecated This rule is deprecated, as ArrayResult is rarely used and the guessed column keys need manual correction anyway.
*/
final class AddArrayResultColumnNamesRector extends AbstractRector implements ComposerPackageConstraintInterface
final class AddArrayResultColumnNamesRector extends AbstractRector implements ComposerPackageConstraintInterface, DeprecatedInterface
{
public function provideComposerPackageConstraint(): ComposerPackageConstraint
{
Expand Down
Loading