Repository navigation
[perf] Check method name before type inference in ExecuteQueryParamsToBindValueRector - #537
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The rule walks the statements of a stmts-aware node and, for every
MethodCallit finds, ranisObjectType()(type inference) on the caller before checking the method name - so type resolution ran on every method call in the body, including the majority that are notexecuteQuery()and bail on the name anyway.Reorders the
NodeFinderpredicate to compare the cheap method name first. Pure reorder - both conditions are still ANDed.Numbers
Micro bench (
bench/execute_query_params_name_guard_bench.php, shipped here), refactor() over a method body of 300 non-executeQuery calls, 200 repeats, CPU (user+sys):~1.25x on the common bail path (the statement walk itself dominates the rest). Full test suite stays green (306 tests).