Repository navigation
[perf] Match array_key_first/last in a single statement traversal - #416
Merged
TomasVotruba merged 1 commit intoOct 21, 2026
Merged
Conversation
TomasVotruba
deleted the
perf-downgrade-array-key-first-last-single-traversal
branch
October 21, 2026 08:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DowngradeArrayKeyFirstLastRector::refactor()ranExprInTopStmtMatcher::match()twice per statement - one full subtree traversal to findarray_key_first(), then a second full traversal forarray_key_last(). For the overwhelming majority of statements (which contain neither) that is two full traversals of the expression tree where one suffices.This matches either name in a single traversal and dispatches on the matched name.
array_key_firstkeeps priority (checked first on the matched node), so behaviour is unchanged.Numbers
Micro bench (
bench/array_key_first_last_single_traversal_bench.php, shipped here), refactor() over 300 statements containing neither call, 200 repeats, CPU (user+sys):~1.46x on the common path. The rule's own test (15 cases) stays green.