Repository navigation
Cap FileProcessor fixed-point loop at 5 iterations - #8715
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
tv-fileprocessor-iteration-cap
branch
3 times, most recently
from
October 19, 2026 20:14
8bace8f to
f2047cc
Compare
TomasVotruba
changed the title
Guard the rule do-while loop so a non-idempotent rule cannot loop forever; stop after 5 passes and surface it (throw in tests, SystemError otherwise).
TomasVotruba
force-pushed
the
tv-fileprocessor-iteration-cap
branch
from
October 19, 2026 20:40
f2047cc to
fa18276
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule do-while loop in
FileProcessorruns until a file stops changing. Add a safety cap so a rule that keeps changing the same node cannot loop forever: in tests it throws (a rule bug must surface), in normal runs it returns aSystemErrorfor that file.A well-behaved rule set settles within a couple of passes, so 5 leaves clear headroom while still catching a runaway loop early.