Skip to content

Convert nested closures to arrow functions in a single pass #8716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 19, 2026
Merged

Convert nested closures to arrow functions in a single pass #8716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions rules/Php74/Rector/Closure/ClosureToArrowFunctionRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@ public function refactor(Node $node): ?Node
return null;
}

// convert a directly nested closure in the same pass, so each closure node is handled once
// instead of leaving the inner one for another traverse pass
if ($returnExpr instanceof Closure) {
$nestedArrowFunction = $this->refactor($returnExpr);
if ($nestedArrowFunction instanceof Expr) {
$returnExpr = $nestedArrowFunction;
}
}

$attributes = $node->getAttributes();
unset($attributes[AttributeKey::ORIGINAL_NODE]);

Expand Down
Loading