Repository navigation
[perf] Bucket generic tags by name in AnnotationToAttributeRector - #8745
Merged
Merged
Conversation
processGenericTags() scanned the whole configured annotation list for every generic doc tag, running strtolower() on both sides per entry. Bucket the list by lowercased tag once in configure() and look the tag up directly. The doctrine-annotation path (matchAnnotationToAttribute, hasClassName) keeps the flat list, as it matches by resolved class name, not tag string. bench/annotation_to_attribute_generic_tag_bench.php (400 entries, 100 generic-tag methods): 259.0 -> 20.8 us/call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the configurable-rule config-scan cleanup (#8734 … #8744).
AnnotationToAttributeRector::processGenericTags()scanned the whole configured annotation list for every generic doc tag, runningstrtolower()on both sides per entry.Bucket the list by lowercased tag once in
configure()and look the tag up directly. The doctrine-annotation path (matchAnnotationToAttribute,hasClassName) keeps the flat list - it matches by resolved class name, not by tag string, so it is left as is.Numbers
bench/annotation_to_attribute_generic_tag_bench.php(400 entries, 100 generic-tag methods, CPU time, same run):Scales with configured-list size. Full
rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector(65 tests) green, PHPStan and ECS clean.