Repository navigation
Replace deprecated PHPStan TypeUtils::flattenTypes with local TypeFlattener - #8749
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPStan\Type\TypeUtils::flattenTypes()is deprecated upstream and slated for removal.TypeFactoryis the only place insrc//rules/that calls it (3 sites).This adds a local
TypeFlattener::flatten()that reimplements the method faithfully - union unwrapping plus the constant-array power-set expansion (with the same 16384 variant bail-out and an inlined cartesiancombinations) - and swaps the 3 call sites. Removes the lastuse PHPStan\Type\TypeUtilsin the codebase.Behavior is unchanged; full test suite passes (4990 tests), PHPStan level 8 and ECS clean.